Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39625 )
Change subject: soc/intel/xeon_sp: Modify FSP-T code caching parameters
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39625/2/src/soc/intel/xeon_sp/bootb...
File src/soc/intel/xeon_sp/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39625/2/src/soc/intel/xeon_sp/bootb...
PS2, Line 34: .CodeRegionLength = (UINT32)CONFIG_BIOS_REGION_SIZE,
why not hardcode to 16MiB? Thats the maximum FSP-T can support. […]
Do you mean like this?
.CodeRegionBase = (UINT32)(0x100000000ULL - 0x1000000),
.CodeRegionLength = 0x1000000,
I'll wait for others' opinion a bit.
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39625
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibba133d9f8fdfbdfae9a0e8e698356a3ca9ba424
Gerrit-Change-Number: 39625
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 18 Mar 2020 08:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment