Attention is currently required from: Saurabh Mishra, Tarun Tuli, Subrata Banik, Kapil Porwal.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69961 )
Change subject: edk2-stable202111: Update MdePkg/Include/IndustryStandard/SmBios.h
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69961/comment/003b9498_01d3a503
PS1, Line 11: Kconfig.
Also can you please raise a bug in EDK2 to fix this in proper? […]
hi Subrata,
the definition conflict comes between following 2 files first is from coreboot and second is from EDK2.
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
Same error will not be replicate in EDK2 standalone.
To solve this for in all platforms we can rename members of enum defined in coreboot headers. if you think it is correct path for all future platforms, I will start preparing change for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69961
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc65d05a8b4bd232b91184ff8cd52a20cd3538ae
Gerrit-Change-Number: 69961
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Vikrant Jadeja
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 07:26:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment