Attention is currently required from: Felix Singer, Name of user not set #1003506, Martin Roth, Angel Pons, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52594 )
Change subject: mainboard: Add Synology DS918+ ......................................................................
Patch Set 6:
(62 comments)
File src/mainboard/synology/ds918plus/early_gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/8365a377_0c47faff PS6, Line 40: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/1e8b55ac_5cdc0723 PS6, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/bb26dbac_4b29a9b8 PS6, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/620679d0_fce96b13 PS6, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/9b0432ec_d69e5b47 PS6, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
File src/mainboard/synology/ds918plus/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/cfe73b4d_1169db8a PS6, Line 47: PAD_CFG_GPI_APIC_IOS(GPIO_33, DN_20K, DEEP, EDGE_SINGLE, NONE, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/5f1702f5_c72c9edb PS6, Line 52: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/6ff70d56_15394456 PS6, Line 53: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/2dc5f77b_07424e3d PS6, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_40, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/c9bb3c18_4b5f618b PS6, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_41, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/a4c63472_9123d42a PS6, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/e3ac0ca0_28abb5ab PS6, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/65d2ac0b_ba1e6c59 PS6, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART1_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/4be54555_7099bb6d PS6, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/1f5c09a5_fb26ea52 PS6, Line 85: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_DT, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/e94ff6b6_93ac97c4 PS6, Line 86: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_RSP, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/0f872539_a7fdc9dd PS6, Line 102: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_193, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/88fafd22_c6393553 PS6, Line 103: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_194, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/943bad0b_981c860b PS6, Line 104: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_195, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/7f6e3283_e19ae393 PS6, Line 114: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS0, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/dc1c26db_aa35d610 PS6, Line 115: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS1, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/04caf3df_a7287f61 PS6, Line 117: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_RXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/641957ec_7f44a7ba PS6, Line 118: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_TXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/725c8a01_4ecacc39 PS6, Line 119: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_CLK, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/b9f89da1_278f9661 PS6, Line 121: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_RESET_B, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/183a3fc2_7645f3c5 PS6, Line 126: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_STDBY, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/f04f2be3_73ffbbb8 PS6, Line 137: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_81, DN_20K, DEEP, NF2, TxDRxE, ENPD), /* AVS_I2C4_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/402c7c15_c7f3331b PS6, Line 139: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_83, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_DMIC_DATA_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/892e4359_5d8713a8 PS6, Line 147: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_91, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_I2S3_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/83e78156_6728e6f8 PS6, Line 157: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_104, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_CLK */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/b63d6874_4b479e9d PS6, Line 158: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_105, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/7e7524db_e145205a PS6, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/c289359a_eb7fc84c PS6, Line 160: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_109, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/5febd422_48368e5a PS6, Line 161: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/e677cfd0_80921564 PS6, Line 177: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_124, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/bc2eec39_db9f648b PS6, Line 178: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_125, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/c72750b0_f409c9c3 PS6, Line 179: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/e1541d1b_0edaa52c PS6, Line 180: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/2d238ade_ccc4185f PS6, Line 181: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/4005d184_9fed7869 PS6, Line 182: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/8e5e33da_845cbb43 PS6, Line 183: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/fea2654e_71f1ac2a PS6, Line 184: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/544e57e8_ec0d5d91 PS6, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/96e2ff43_6795b650 PS6, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/8633ad50_5726cd46 PS6, Line 187: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_134, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/d4d6ea9f_b9ba330c PS6, Line 188: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_135, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/ee46a0ed_ad011c24 PS6, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_136, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/1c4e959e_5fe90e6d PS6, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_137, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/9052ff2c_1d81329f PS6, Line 191: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_138, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/54e95774_98f00bd3 PS6, Line 192: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_139, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/a3b11792_a471d237 PS6, Line 203: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ0_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/d779208e_33a79af9 PS6, Line 204: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/eb7386c2_7db4d381 PS6, Line 205: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_211, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ2_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/c4f864f0_619d7872 PS6, Line 206: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_212, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ3_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/178d7c91_1db4c632 PS6, Line 216: PAD_CFG_NF_IOSTANDBY_IGNORE(PMU_RESETBUTTON_B, NONE, DEEP, NF1), /* PMU_RSTBTN_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/aff151db_82d9886c PS6, Line 221: PAD_CFG_GPO_IOSSTATE_IOSTERM(PMU_WAKE_B, 1, DEEP, UP_20K, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/7a2d1a1e_25fd8f8c PS6, Line 264: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_CLKOUT1, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_CLKOUT1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/cbcf18bc_274d49b7 PS6, Line 265: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD0, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/378464d9_31da75a5 PS6, Line 266: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD1, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/7d64b98e_d6093eee PS6, Line 267: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD2, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/3fac4cd3_fc5ba3d4 PS6, Line 268: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD3, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118393): https://review.coreboot.org/c/coreboot/+/52594/comment/aef654e2_6a5335c5 PS6, Line 270: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_FRAMEB, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_FRAMEB */ line over 96 characters