HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: lib/cbmem: Change the return type of cbmem_top_chipset to uinptr_t ......................................................................
Patch Set 31:
(2 comments)
This patch didn't even build. please set it as "work in progress" Thx
https://review.coreboot.org/c/coreboot/+/43756/31//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43756/31//COMMIT_MSG@7 PS31, Line 7: lib/cbmem you didn't touched a single file in "src/lib"
https://review.coreboot.org/c/coreboot/+/43756/31/src/northbridge/intel/i945... File src/northbridge/intel/i945/memmap.c:
https://review.coreboot.org/c/coreboot/+/43756/31/src/northbridge/intel/i945... PS31, Line 61: uintptr_t cbmem_top_chipset(void) : { : uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB); : return (uintptr_t) top_of_ram; : } uintptr_t cbmem_top_chipset(void) { return ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB); }