Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60479 )
Change subject: mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ......................................................................
mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
Replace `Subtract (a, b, c)` with `c = a - b`.
Change-Id: I22088a584c1d6d5188cb74ff8b03f51ea02e4b68 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl M src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/60479/1
diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index 7216d33..c5ae2448 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -52,7 +52,7 @@ Decrement (Local1) If (LGreater (Local1, 0x10)) { - Subtract (Local1, 0x0F, Local1) + Local1 = Local1 - 0x0F Store (ShiftLeft (Local1, 0x14), MEM2) Store (0x01000000, MS00) Store (MS00, MS01) diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl index 0ba808d..400a5d7 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl @@ -44,8 +44,8 @@ And (_SB.PCI0.TOLM, 0xF800, Local1) ShiftRight (Local1, 0x04, Local1) ShiftLeft (Local1, 0x14, MEML) - Subtract (IO_APIC_ADDR, 0x01, MEMH) - Subtract (IO_APIC_ADDR, MEML, LENM) + MEMH = IO_APIC_ADDR - 1 + LENM = IO_APIC_ADDR - MEML
Return (PBRS) }