build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: sc7180: Add display 10nm phy & pll programming support [Patch 1 of 3] ......................................................................
Patch Set 6:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/mdss_6_2_0.h:
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 462: #define CDM_HDMI_PACK_OP_MODE REG_MDP 0x7A400 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 463: #define MDP_OUT_CTL_0 REG_MDP 0x01410 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 464: #define MDP_INTF_3_INTF_CONFIG REG_MDP 0x6C804 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 465: #define CDM_CDWN2_OUT_SIZE REG_MDP 0x7A330 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 466: #define CDM_CDWN2_OP_MODE REG_MDP 0x7A300 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 467: #define CDM_CDWN2_CLAMP_OUT REG_MDP 0x7A304 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/6/src/soc/qualcomm/sc7180/inc... PS6, Line 468: #define CDM_CSC_10_OP_MODE REG_MDP 0x7A200 Macros with complex values should be enclosed in parentheses