[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/skyrim: override Markarth PCIe config

[Martin Roth (Code Review)]

Attention is currently required from: John Su, Jason Nien, Paul Menzel, Chris Wang, Karthik Ramasubramanian, Patrick Huang.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74133 )

Change subject: mb/google/skyrim: override Markarth PCIe config
......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74133/comment/ebb02db8_75636458 
PS3, Line 7: mb/google/skyrim
> Shouldn’t variant names be mentioned in the prefix?

Nah, that just makes the commit message longer without adding useful information.  This says which variant it is without needing to add the /variant/ which is completely useless.

https://review.coreboot.org/c/coreboot/+/74133/comment/4cfc0b79_8ecbeb4c 
PS3, Line 8:
> I’d start by describing the problem. […]

It does start by describing the problem. Markarth port 1 is used for eMMC, not an SD controller. It doesn't really matter if this is based on schematics or there's a working device, that's just how the design is.

https://review.coreboot.org/c/coreboot/+/74133/comment/983dc182_3b2a176a 
PS3, Line 17: TEST=emerge-skyrim coreboot chromeos-bootimage
> Did you test this on a real device?

I've tested it on whiterun.  This mirrors what was done there.  See CB:73441