Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35119 )
Change subject: soc/sifive/fu540: Support booting from SD card
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35119/7/src/mainboard/sifive/hifive...
File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/c/coreboot/+/35119/7/src/mainboard/sifive/hifive...
PS7, Line 28: #define BLOCK_SIZE 512
where does that value come from? is it mmc specific?
This is set when the sd card is initialized, see the spi_sdcard_init function in src/drivers/spi/spi_sdcard.c
```c
/* CMD16, set block length to 512 bytes */
if (spi_sdcard_do_command(card, SET_BLOCKLEN, 512, NULL))
return -1;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18948d31c0bf0bf9d641480a35fc710b9ee8ae84
Gerrit-Change-Number: 35119
Gerrit-PatchSet: 9
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Sep 2019 05:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment