build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34509 )
Change subject: mb/google/octopus: Override DDI1 DDC SDA/SCL for HDMI ......................................................................
Patch Set 1:
(51 comments)
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/meep/gpio.c:
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 31: PAD_NC(GPIO_104, UP_20K), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 31: PAD_NC(GPIO_104, UP_20K), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 33: /* HV_DDI1_DDC_SDA */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 34: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, NONE, DEEP, NF1, HIZCRx1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 34: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, NONE, DEEP, NF1, HIZCRx1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 35: DISPUPD), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 35: DISPUPD), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 36: /* HV_DDI1_DDC_SCL */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 37: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, NONE, DEEP, NF1, HIZCRx1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 37: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, NONE, DEEP, NF1, HIZCRx1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 38: DISPUPD), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 38: DISPUPD), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 39: /* EN_PP3300_TOUCHSCREEN */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 40: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 40: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 41: DISPUPD), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 41: DISPUPD), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 46: uint32_t sku_id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 46: uint32_t sku_id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 47: sku_id = get_board_sku(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 47: sku_id = get_board_sku(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 49: switch (sku_id) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 49: switch (sku_id) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 50: case SKU_33_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 50: case SKU_33_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 50: case SKU_33_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 51: case SKU_34_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 51: case SKU_34_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 51: case SKU_34_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 52: case SKU_35_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 52: case SKU_35_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 52: case SKU_35_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 53: case SKU_36_DORP: 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 53: case SKU_36_DORP: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 53: case SKU_36_DORP: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 54: *num = ARRAY_SIZE(hdmi_sku_override_table); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 54: *num = ARRAY_SIZE(hdmi_sku_override_table); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 55: return hdmi_sku_override_table; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 55: return hdmi_sku_override_table; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/meep/include/variant/sku.h:
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 21: SKU_33_DORP = 33, /* HDMI */ 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 21: SKU_33_DORP = 33, /* HDMI */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 21: SKU_33_DORP = 33, /* HDMI */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 22: SKU_34_DORP = 34, /* HDMI+Kblight */ 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 22: SKU_34_DORP = 34, /* HDMI+Kblight */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 22: SKU_34_DORP = 34, /* HDMI+Kblight */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 23: SKU_35_DORP = 35, /* HDMI+TS */ 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 23: SKU_35_DORP = 35, /* HDMI+TS */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 23: SKU_35_DORP = 35, /* HDMI+TS */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 24: SKU_36_DORP = 36, /* HDMI+TS+KBlight */ 'DORP' may be misspelled - perhaps 'DROP'?
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 24: SKU_36_DORP = 36, /* HDMI+TS+KBlight */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34509/1/src/mainboard/google/octopu... PS1, Line 24: SKU_36_DORP = 36, /* HDMI+TS+KBlight */ please, no spaces at the start of a line