Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37309 )
Change subject: soc/intel/cannonlake: Clean up report_cpu_info() function ......................................................................
Patch Set 2:
(3 comments)
Could have been two commits.
https://review.coreboot.org/c/coreboot/+/37309/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37309/2//COMMIT_MSG@10 PS2, Line 10: function. Fits on the line above.
https://review.coreboot.org/c/coreboot/+/37309/2//COMMIT_MSG@14 PS2, Line 14: Succesfully Successfully
https://review.coreboot.org/c/coreboot/+/37309/2/src/soc/intel/cannonlake/bo... File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/37309/2/src/soc/intel/cannonlake/bo... PS2, Line 166: char cpu_name[49]; Why was it 50 before?