[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Override uart base address via VPD variable

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )

Change subject: mb/ocp/deltalake: Override uart base address via VPD variable
......................................................................

Patch Set 7:

(2 comments)

Thanks, Bryant.

https://review.coreboot.org/c/coreboot/+/45408/3/src/mainboard/ocp/deltalake... 
File src/mainboard/ocp/deltalake/uart.c:

https://review.coreboot.org/c/coreboot/+/45408/3/src/mainboard/ocp/deltalake... 
PS3, Line 8: int hex2int(const char *hexstr)
> src/lib/hexstrtobin. […]

Bryant, please just use hexstrrtobin().

https://review.coreboot.org/c/coreboot/+/45408/3/src/mainboard/ocp/deltalake... 
PS3, Line 35: 	if (vpd_gets(UART_IOPORT, port, VPD_LEN, VPD_RW_THEN_RO))
> This sounds like a fundamentally bad idea. VPD was not meant to be used for things like this. […]

Bryant, can we switch to use CBFS file (such as fallback/uart_ioport)? We normally use SOL, and it is rare to switch to other ioport. Thanks!