Attention is currently required from: Shreesh Chhabbi.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 )
Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49766/comment/a0050c48_1e79d3f0
PS3, Line 236: LpmStateEnableMask
Hi Furquan, I did not find the upds for external bypass, external clk gate and external phy gate. […]
Hi Shreesh, I was referring to adding configs for external bypass, external clk and phy gate to `soc_intel_alderlake_config` here: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/alderlake/c...
And then update current boards (tglrvp and volteer) to set these as per their design. Then this function can set the disable mask appropriately. Does that make sense?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f2ac8b72d0c9b05bc02c092188d0c742cc83af9
Gerrit-Change-Number: 49766
Gerrit-PatchSet: 8
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 18:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-MessageType: comment