Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35410 )
Change subject: [WIP]arch/arm: Implement FIT support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35410/1/src/arch/arm/fit_payload.c File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/35410/1/src/arch/arm/fit_payload.c@... PS1, Line 29: #define SECTION_ALIGN 64 4096 or 2MiB?
https://review.coreboot.org/c/coreboot/+/35410/1/src/arch/arm/fit_payload.c@... PS1, Line 83: "boot a RISC-V kernel!\n"); armv7
https://review.coreboot.org/c/coreboot/+/35410/1/src/arch/arm/fit_payload.c@... PS1, Line 85: /* TODO: Fall back to the ROM FDT? */ there's no ROM FDT on armv7
https://review.coreboot.org/c/coreboot/+/35410/1/src/arch/arm/fit_payload.c@... PS1, Line 106: * the need to relocate prior to compression. doesn't that apply to zImage only? Usually FIT uses Image.