Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37730 )
Change subject: util/autoport: correct build errors of produced files ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go File util/autoport/bd82x6x.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go@a2... PS2, Line 260: PCISlot{PCIAddr: PCIAddr{Dev: 0x1f, Func: 0}, writeEmpty: true, additionalComment: "LPC bridge"},
This might be the first "LPC bridge" in "LPC bridge PCI-LPC bridge"?
Yep, seems like it. I'll also rename some of these later. For example, IIRC, SATA controller #1 is for AHCI and #2 is for legacy mode.
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go@a2... PS2, Line 279: PCI-
Well, if I take `PCI-` out of `LPC bridge PCI-LPC bridge` what will be left […]
Yes. I don't know what I was thinking when I did this