Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/28249
Change subject: lib/gpio.c: Validate num_gpio ......................................................................
lib/gpio.c: Validate num_gpio
In function _gpio_base3_value(), if num_gpio is 0 it'll cause the return of an undefined value, as no for loop will be executed. Assert that it's not 0.
BUG=b:112253891 TEST=Build and boot grunt.
Change-Id: I2b6537900fa41ebbee0171959f3ce236d360bc80 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/lib/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28249/1
diff --git a/src/lib/gpio.c b/src/lib/gpio.c index 0656dfb..482f62d 100644 --- a/src/lib/gpio.c +++ b/src/lib/gpio.c @@ -82,7 +82,7 @@ int index; int temp; char value[32]; - assert(num_gpio <= 32); + assert((num_gpio <= 32) && (num_gpio > 0));
/* Enable internal pull up */ for (index = 0; index < num_gpio; ++index)