Hello Hung-Te Lin, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48201
to look at the new patch set (#9).
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS ......................................................................
Makefile.inc: Fix empty output when processing C struct files in CBFS
When passing $(@) to eval command, $(@) is replaced by empty string, Also, the $(@) in cbfs-files-processor-struct is a temporary file name, so we should quote it by an extra '$' or use the arg ($1 or $2) directly.
Also, $(@)=$2 is actually a temporary file and what we want is the source file so using $1 is more correct.
For example: cbfs-files-processor-struct= \ $(eval $(2): $(1) $(obj)/build.h $(KCONFIG_AUTOHEADER); \ # ** $(@) is empty string instead of $(2) ** printf " CC+STRIP $(@) \n"; \ # ** $(1) contains the name of source file ** printf " CC+STRIP $(1) \n"; \ ......)
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: Id6a66e25d7dfe8fe6410e517593ed22a438d2f82 --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/48201/9