Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46058 )
Change subject: soc/amd/picasso: add monotonic_timer
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46058/1/src/soc/amd/picasso/monoton...
File src/soc/amd/picasso/monotonic_timer.c:
https://review.coreboot.org/c/coreboot/+/46058/1/src/soc/amd/picasso/monoton...
PS1, Line 8: void timer_monotonic_get(struct mono_time *mt)
Some comments around these functions would be helpful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifced4a84071be8da547e252167ec21cd42f20ccc
Gerrit-Change-Number: 46058
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Oct 2020 16:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment