Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37692 )
Change subject: superio/common/ssdt: Make disabled PNP devices ACPI compliant
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37692/2/src/superio/common/ssdt.c
File src/superio/common/ssdt.c:
https://review.coreboot.org/c/coreboot/+/37692/2/src/superio/common/ssdt.c@2...
PS2, Line 206: /* To be ACPI compliant, always write a _HID */
: acpigen_write_name_string("_HID", ACPI_HID_PNP);
why not just move the block from lines 228-243 above line 205?
Done
https://review.coreboot.org/c/coreboot/+/37692/5/src/superio/common/ssdt.c
File src/superio/common/ssdt.c:
https://review.coreboot.org/c/coreboot/+/37692/5/src/superio/common/ssdt.c@2...
PS5, Line 207: /* To be ACPI compliant, always write a _HID */
Can you add the section from the specification?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419a08bd6a3570fb4e1ae31bef4f9ccd6836fe1b
Gerrit-Change-Number: 37692
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Dec 2019 08:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment