Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37925 )
Change subject: mainboard/google/puff: Add GPIO configuration
......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37925/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/gpio.c:
https://review.coreboot.org/c/coreboot/+/37925/3/src/mainboard/google/hatch/...
PS3, Line 76: PAD_CFG_NF(GPP_F23, NONE, DEEP, NF1),
This can be just left as NC. I don't think there is any functionality on NF1 here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae20d2262c910044dde84f10d795f4aee3318532
Gerrit-Change-Number: 37925
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Dec 2019 03:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment