[coreboot-gerrit] Change in ...coreboot[master]: google/krane: Add Panel auo kd101n80-45na support.

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: google/krane: Add Panel auo kd101n80-45na support.
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... 
PS2, Line 381: 			((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf);
This is wrong. Also, this is fragile as you don't specify the ID exact value in the enum.

Please do this instead:

switch (sku_id() >> KRANE_PANEL_ID_BIT_POSITION) {
case 0x0:
    return PANEL_KRANE_AUO_KD101N80_45NA;
case 0x1: /* Incorrect strapping for BOE on rev3 */
case 0xb:
    return PANEL_KRANE_BOE_TV101WUM_NL6;
default:
    return PANEL_KRANE_UNKNOWN;
}