Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................
Patch Set 13: Code-Review+1
(3 comments)
Nice.
https://review.coreboot.org/c/coreboot/+/34359/13/Documentation/mainboard/le...
File Documentation/mainboard/lenovo/t440p.md:
https://review.coreboot.org/c/coreboot/+/34359/13/Documentation/mainboard/le...
PS13, Line 23: ```
: 00000000:00000fff fd
: 00001000:00002fff gbe
: 00003000:004fffff me
: 00500000:00bfffff bios
: ```
You could just indent the “code block” with four spaces, and remove the ``` tags.
https://review.coreboot.org/c/coreboot/+/34359/13/Documentation/mainboard/le...
PS13, Line 30: in
Remove?
https://review.coreboot.org/c/coreboot/+/34359/13/Documentation/mainboard/le...
PS13, Line 45:
Add tested with Arch Linux [version] with Linux [version].
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56a6b94197789a83731d8b349b8ba6814bf57ca2
Gerrit-Change-Number: 34359
Gerrit-PatchSet: 13
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Oct 2019 14:06:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment