Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45535 )
Change subject: soc/intel/common/block/acpi: add code for CPPC entries generation ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... PS8, Line 370: core
Is this `virtual core` aka. thread? Otherwise it would seem that this is […]
Well, that naming scheme is a bit... unclear, but that's what common/block/acpi already does. We can clarify that ofc.
TBH I'm not yet convinced that the loop generate_cpu_entries is correct at all.
Anyway, the global CPPC entry shall get added once per package only. The (logical) cores each get a _CPC method returning that CPPC (GCPC in cb) entry.
`core` is the `core_id` from generate_cpu_entries() which *should* be the APIC id (total number of cores for the loop comes from dev_count_cpu()).
https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... PS8, Line 372: /* version 2 */
Is the comment really necessary? If you want to name arguments, you could pass […]
yay, copy-pasta! came from the original version in skl; will drop that...