Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48564 )
Change subject: soc/amd/cezanne: add GPIO definitions
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48564/2/src/soc/amd/cezanne/include...
File src/soc/amd/cezanne/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/48564/2/src/soc/amd/cezanne/include...
PS2, Line 3: AMD_PICASSO_GPIO_H
change name
Done
https://review.coreboot.org/c/coreboot/+/48564/2/src/soc/amd/cezanne/include...
PS2, Line 116: #define GPIO_10_IOMUX_S0A3 1
nit, it looks like 2 is missing. PPR calls it reserved. could consider a comment for "reserved".
done for all comments and one more
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67930267a89ba0c64ec7e40e2bfa30a0618d104b
Gerrit-Change-Number: 48564
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Assignee: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Dec 2020 14:06:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment