Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation
Oops...
Done
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation
documentation
Already done.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
All markdown lines need to be wrapped at a maximum of 72 characters. […]
Ok. Will fix, but also change the text as I'll take my own pictures.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 40: no, use dediprog
Now I'm curious about what "in circuit flashing" means. […]
I'm not sure, as I copied some of it from a board that looked like having very complete documentation. Maybe I should change it to "Flash programming" and "dediprog header"
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.jpg:
PS1:
Images should have a max width of 700 pixels: […]
Will take my own picture. Might need help labeling.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
PS1:
This might be better included as text.
Will do.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
PS1:
Again, take your own photo? If you need help labeling it, I could help with that.
Will do.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
PS1:
Again, text instead of an image?
Will do.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... File Documentation/soc/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... PS1, Line 5: ## Technology
Make the merlin falcon documentation a separate commit?
Sure
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 3: ## Abstract
Add links via the internet archive? […]
Thanks, nice link.