Attention is currently required from: Hung-Te Lin, Paul Menzel, Xixi Chen.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61133 )
Change subject: soc/mediatek/mt8186: Support DRAM fast calibration using blob
......................................................................
Patch Set 20:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61133/comment/3cd57238_ffc7596d
PS19, Line 9: For the current SoCs the source code for DRAM fast calibration was added
: to the source code repository. For MT8186 the DRAM fast calibration
: source code won’t be published and put under a FLOSS license. The blob
: has to be used to do this.
What about this: […]
Done
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61133/comment/23cfe3c3_825dd6a3
PS19, Line 146: /* Set FAST_K flag */
I think the code below is simple enough to explain itself; instead the comment should describe how/w […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If25a7dd6aa6261ecff79a1b4df8b1f2e53d896dc
Gerrit-Change-Number: 61133
Gerrit-PatchSet: 20
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ron Minnich
rminnich@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 25 Jan 2022 10:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment