Attention is currently required from: Alexander Couzens, Angel Pons, Evgeny Zinoviev, Kevin Keijzer, Patrick Rudolph.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/81879?usp=email )
Change subject: mb/*: Copy bd82x6x boards' USB port config into devicetree
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81879/comment/bd5ba331_6e06beac?usp... :
PS1, Line 11: otherwise the contents are reformatted
: into 3-4 lines with extra spaces removed.
Please don't. It makes reviewing this change much more challenging.
Done
File src/mainboard/apple/macbookair4_2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81879/comment/101972bb_bbd197b5?usp... :
PS2, Line 36: }"
Working to address these. Then again mb/google/puff has lots of such array ends.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81879?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia8a967eb3466106f3a34e024260e13d02f449a25
Gerrit-Change-Number: 81879
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Sat, 25 May 2024 16:26:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com