[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Iru Cai.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39398?usp=email )

Change subject: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant
......................................................................


Patch Set 4:

(1 comment)

File src/mainboard/hp/snb_ivb_laptops/variants/8560w/gpio.c:

https://review.coreboot.org/c/coreboot/+/39398/comment/349e2cff_ce7c9f69 :
PS4, Line 158: 	.gpio57 = GPIO_LEVEL_LOW,
That's `WLAN_TRN_OFF#`, so if Wi-Fi doesn't work try setting this to `GPIO_LEVEL_HIGH`



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/39398?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15181792b1efa45a2a94d78e43c6257da1acf950
Gerrit-Change-Number: 39398
Gerrit-PatchSet: 4
Gerrit-Owner: Iru Cai <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Iru Cai <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Riku Viitanen <[e-mail]>
Gerrit-Attention: Felix Singer <[e-mail]>
Gerrit-Attention: Iru Cai <[e-mail]>
Gerrit-Comment-Date: Wed, 01 May 2024 09:06:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment