Attention is currently required from: Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78224?usp=email )
Change subject: arch/x86/cpu_common: Add cpu_get_c_substate_support ......................................................................
Patch Set 2:
(2 comments)
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/78224/comment/d8cfc764_9a0169ba : PS1, Line 201: (state > 4))
I don't mind it like this, but would fit previous line.
Done
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/78224/comment/7a7e242f_ba3c7a98 : PS1, Line 324: uint8_t cpu_get_c_substate_support(const int lvl);
Rename lvl to state to match .c.
Done