Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )
Change subject: soc/amd/picasso: Add pcie root complex driver
......................................................................
Patch Set 34: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34424/34/src/soc/amd/picasso/root_c...
File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/34424/34/src/soc/amd/picasso/root_c...
PS34, Line 74: * Since XP only implements parts of ACPI 2.0, we can't use a qword
: * here.
do we still care about windows xp? are there still drivers for picasso for xp? or would changing this break something else? let's leave this for now and maybe addressing it in an follow-up patch though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a4a97765151fbcfe4c5d8de200e3e015aaaf2e
Gerrit-Change-Number: 34424
Gerrit-PatchSet: 34
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Comment-Date: Wed, 20 May 2020 00:30:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment