Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37177 )
Change subject: sb/amd/{agesa,pi}/hudson: enable support for AMD common ACPIMMIO blocks
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/agesa/h...
File src/southbridge/amd/agesa/hudson/smbus.c:
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/agesa/h...
PS3, Line 19: #include <amdblocks/acpimmio.h>
not needed?
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/pi/huds...
File src/southbridge/amd/pi/hudson/smbus.c:
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/pi/huds...
PS3, Line 19: #include <amdblocks/acpimmio.h>
Not needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37177
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd014f1ba85efff0c98a0c5ab60d775ac93cbc60
Gerrit-Change-Number: 37177
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Nov 2019 11:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment