10 Mar
2021
10 Mar
'21
8:06 p.m.
Attention is currently required from: Meera Ravindranath. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48416 )
Change subject: mb/intel/adlrvp_p: Support VBT for LP4, LP5 and DDR5 SKUs ......................................................................
Patch Set 16: Code-Review+2
(1 comment)
File src/mainboard/intel/adlrvp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48416/comment/3a544af2_b250ac3b PS16, Line 22: CONFIG_INTEL_GMA_ADD_VBT Not for this change, but I think it would be good to evaluate if we can update CONFIG_INTEL_GMA_VBT_FILE to accept multiple files and loop through those to add to CBFS instead of just a single one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8795cc67d87429eddb31328f1e2a90c346b53533
Gerrit-Change-Number: 48416
Gerrit-PatchSet: 16
Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Comment-Date: Wed, 10 Mar 2021 18:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment