Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Angel Pons, Uwe Poeche, Arthur Heymans, Jan Samek.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67681 )
Change subject: drivers/i2c/ptn3460: Add early init option
......................................................................
Patch Set 8: Code-Review+2
(3 comments)
File src/drivers/i2c/ptn3460/ptn3460.c:
https://review.coreboot.org/c/coreboot/+/67681/comment/ea0dd23f_300c3de2
PS7, Line 78:
I don't find this one excessive
I'm fine with Patchset 8, it's consistent with the existing if-blocks.
File src/drivers/i2c/ptn3460/ptn3460.c:
https://review.coreboot.org/c/coreboot/+/67681/comment/ca8fdd72_048abe80
PS8, Line 6: #include <bootstate.h>
very nit: preserve existing alphabetical order?
https://review.coreboot.org/c/coreboot/+/67681/comment/25993b2f_cfc42311
PS8, Line 69: */
nit: add space before comment end
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67681
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5424d062b3fb63c78cfced3971376353be11c504
Gerrit-Change-Number: 67681
Gerrit-PatchSet: 8
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Comment-Date: Wed, 21 Sep 2022 08:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment