Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32023 )
Change subject: src: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 11: Code-Review+2
(4 comments)
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/torpedo/BiosCallOu... File src/mainboard/amd/torpedo/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/torpedo/BiosCallOu... PS8, Line 19: #include "Hudson-2.h"
I think that for AMD we can't.
Fine for me.
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... File src/northbridge/amd/agesa/family14/dimmSpd.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... PS8, Line 23: #include "chip.h"
I think we can't for AMD
OK, leave it as it is
https://review.coreboot.org/#/c/32023/8/src/soc/amd/stoneyridge/BiosCallOuts... File src/soc/amd/stoneyridge/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/soc/amd/stoneyridge/BiosCallOuts... PS8, Line 26: #include "chip.h"
not sure if we can with AMD
Fine for me.
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/cimx/sb800/spi.c File src/southbridge/amd/cimx/sb800/spi.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/cimx/sb800/spi.c... PS8, Line 24: #include "SBPLATFORM.h"
not sure if we can
Fine for me.