Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Paul Menzel, Johnny Li, Shuming Chu (Shuming), Angel Pons, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 )
Change subject: drivers/ocp: add VPD processing framework
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68784/comment/b3ce16ae_c1a77223
PS4, Line 10: configruation
typo: configuration
File src/drivers/ocp/include/vpd.h:
https://review.coreboot.org/c/coreboot/+/68784/comment/87be4a2c_d14146b3
PS4, Line 48: enum cxl_memory_mode {
: CXL_DISABLED, // 0
: CXL_SYSTEM_MEMORY, // 1
: CXL_SPM,//2
: CXL_MODE_MAX,
: };
Comments don't get compiled in, let's turn them into code:
```
enum cxl_memory_mode {
CXL_DISABLED = 0,
CXL_SYSTEM_MEMORY = 1,
CXL_SPM = 2,
CXL_MODE_MAX,
};
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I705bea348b1611f25ccbd798b77cfee22ec30f0f
Gerrit-Change-Number: 68784
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sun, 13 Nov 2022 11:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment