Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34170 )
Change subject: libpayload/x86: Try to discover invariant TSC rate
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34170/4/payloads/libpayload/arch/x8...
File payloads/libpayload/arch/x86/timer.c:
https://review.coreboot.org/c/coreboot/+/34170/4/payloads/libpayload/arch/x8...
PS4, Line 172: /*
newline above
https://review.coreboot.org/c/coreboot/+/34170/4/payloads/libpayload/arch/x8...
PS4, Line 176: _rdmsr(MSR_PLATFORM_INFO) >> 8
nit: brackets for readability?
https://review.coreboot.org/c/coreboot/+/34170/4/payloads/libpayload/arch/x8...
PS4, Line 186: cpu_khz
hm, somehow I seem to miss what this global variable is useful for (yeah I know, it was there before but...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6607ee2a8b41c2be9dc1bb4f1e23e652bb33889
Gerrit-Change-Number: 34170
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 22:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
