Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )
Change subject: lib: Refactor ux_locales_get_text API ......................................................................
Patch Set 5:
(4 comments)
File src/include/ux_locales.h:
https://review.coreboot.org/c/coreboot/+/86283/comment/7e1f13fd_cca3ca26?usp... : PS5, Line 23: const char *ux_locales_get_text(const char *name, const char *fallback_text);
Why should we still keep this API around? I think we should switch everything to using IDs.
Please take a look at https://github.com/coreboot/coreboot/blob/main/tests/lib/ux_locales-test.c#L..., related to unit-tests for ux-locales where certain expectation about default text won't meet as we are now limiting the msg_id and default test within the ux_locales.c itself. Meaning any outside caller of `ux_locales_get_text_by_id()` without passing valid msg_id other than what present inside ux_locales.h would ended up getting a text msg "Trying to display unknown message?". This is something that would make ux_locales unit test fail.
``` enum ux_locale_msg { UX_LOCALE_MSG_MEMORY_TRAINING, UX_LOCALE_MSG_NUM, }; ```
therefore, the consumer of `ux_locales_get_text` is just unit-test whereelse `ux_locales_get_text_by_id` will be in use widely inside coreboot/src
File src/lib/ux_locales.c:
https://review.coreboot.org/c/coreboot/+/86283/comment/fddf4901_44688c44?usp... : PS5, Line 28: "Please do not turn off your device."
+1
Acknowledged
https://review.coreboot.org/c/coreboot/+/86283/comment/8cac1e3b_daffa344?usp... : PS5, Line 32: enum ux_locale_msg locale_msg_id;
+1
Acknowledged
https://review.coreboot.org/c/coreboot/+/86283/comment/aa8a6c72_cc484df9?usp... : PS5, Line 213: switch (msg_id) {
+1 […]
Acknowledged