Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42311 )
Change subject: tests: Complete lib/string-test test case ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@33 PS1, Line 33: struct str_with_l_val_t { Consider adding comments here and for str_with_u_val_t that these are being used to test atol and atoi
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@48 PS1, Line 48: uint32_t atoi returns a signed int
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@190 PS1, Line 190: assert_int_equal assert_int_equal expects signed integers. Once you fix the type for str_with_u_val.value this will be OK