[coreboot-gerrit] Change in coreboot[master]: soc/intel/car: Add support for bootguard CAR

[Gaggery Tsai (Code Review)]

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36682 )

Change subject: soc/intel/car: Add support for bootguard CAR
......................................................................

Patch Set 6:
> Patch Set 6:
> > Patch Set 6:
> > > Patch Set 6:
> > > > I tested this patch and it seems not working with BootGuard enabled.
> > >
> > > Thanks.
> > >
> > > Can you elaborate on the exact state of your coreboot tree? Did you
> > > mix this with your caching patch?
> > >
> > > Also, did you see the comments about MSR 0x139, above? Maybe that's
> > > just what is missing.
> >
> > I picked up other dependency patches with this patch and didn't include my patch.
>
> Hi, thanks for testing. What platform did you test this on? Also, when you mean "not working", does the board reset or hang, or is it something else? AFAIK, not setting MSR 0x139 would make the system reset after some time or when trying to wake up the APs.

I saw it was stuck at post code 0x2A. I will look into it and provide more info later.