Hello Alex Thiessen, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32901
to look at the new patch set (#2).
Change subject: string.h: Move common string functions into .c file ......................................................................
string.h: Move common string functions into .c file
There's no clear reason why most of coreboot's basic string functions are static inline. These functions don't particularly benefit from inlining (at least not notably more than other functions). This patch moves them to string.c to be more consistent with our usual coding practices.
Leaving the ctype functions as static inline because they actually seem small and collapsible enough that inlining seems reasonable.
Also clarified the situation of strdup() and strconcat() a bit more, optimized strrchr() to be single-pass, fixed a bug with using strchr() to find '\0' and got rid of unnecessary register keywords.
Change-Id: I88166ba9876e94dfa3cfc06969c78a9e1bc6fc36 Signed-off-by: Julius Werner jwerner@chromium.org --- M src/include/string.h M src/lib/Makefile.inc M src/lib/string.c 3 files changed, 131 insertions(+), 106 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/32901/2