Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, YH Lin.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63022 )
Change subject: mb/google/brya/variants/crota: init overridetree for crota
......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63022/comment/6d119aab_71a22113
PS8, Line 68: register "usb2_ports[4]" = "USB2_PORT_EMPTY" # Disable USB2_C4
: register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Disable USB2_C6
: register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Type-A MLB Port
: register "usb2_ports[8]" = "USB2_PORT_EMPTY" # Disable USB2_C8
nit: use all tabs for indentation please (there are spaces at the beginning of these lines)
Done.
https://review.coreboot.org/c/coreboot/+/63022/comment/4b1d167c_027bcd5c
PS8, Line 74: register "tcss_ports[1]" = "TCSS_PORT_EMPTY"
same here
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibca9d93a81469730e472a645c607a97a624e9a1c
Gerrit-Change-Number: 63022
Gerrit-PatchSet: 9
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Tue, 29 Mar 2022 01:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment