Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36657 )
Change subject: lib/fmap: Add optional pre-RAM cache
......................................................................
Patch Set 9:
Patch Set 9:
Since this commit I'm getting a new "ERROR: FMAP cache corrupted?!" message on AMD f15h and f16h AGESA boards (this message itself also got added with this commit), which luckily doesn't seem to affect anything. If you would like, I could test your newer FMAP changes to see if this could be fixed.
This code assumes C_ENVIRONMENT_BOOTBLOCK. It's easy to fix. OTOH platforms without it will be dropped after the 4.11 release.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2820436776ef620bdc4481b5cd4b6957764248ea
Gerrit-Change-Number: 36657
Gerrit-PatchSet: 9
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sun, 17 Nov 2019 10:31:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment