Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33114 )
Change subject: Makefile.inc: Fix compilation issue with !CONFIG_ENABLE_STAGE_RAMSTAGE ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/33114/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33114/5//COMMIT_MSG@14 PS5, Line 14: >> rmodules_$(ARCH-ramstage-y) will evaluate as rmodules_
sorry, i didn't get your point. […]
The compiler won't even get to this point. It's all just Makefile variable parsing. However, my point is that if there is nothing referencing the root dependency for the Makefiles the variable evaluation doesn't matter since the rules won't be utilized at all.
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc@20 PS5, Line 20: ifeq ($(CONFIG_STAGE_RAMSTAGE),y)
In case of CONFIG_RAMPAYLOAD is enable (means without ramstage) somehow we have to compile this file […]
But where are these rules being acted upon? e.g. if nothing is referencing sipi.bin then Make should never attempt to execute these rules.