Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )
Change subject: Support for Zotac AD04 added (initial commit)
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(7 comments)
Done and committed for review
Okay, you can try to flash the result. Ensure you have a backup of the flash chip contents, just in case. If unsure how to proceed, feel free to ask around on IRC.
https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/gp...
File src/mainboard/zotac/ad04/gpio_ftns.c:
PS1:
not quite sure. […]
You can hardcode that value for now. Ideally, SMBIOS tables should be generated through chipset code, but AGESA platforms aren't in a great shape...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I184fb55b184c7739824d801524e2a3d1d2573f11
Gerrit-Change-Number: 47056
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1003174
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 21:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1003174
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment