Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33252 )
Change subject: security/tpm/tss/tcg-2.0: Add multi digits support to tlcl_extend()
......................................................................
Patch Set 8:
Patch Set 8:
Hi Frans,
Due to the issues pointed out above, I've uploaded a revert of this patch for now (CB:35351). If you really need this to stay in the tree please let me know within 24h, but then please also commit to fixing the issues I pointed out in a timely manner. Otherwise, I'd like to land the revert and you're welcome to reupload your patch at any time with those issues resolved.
I did not noticed your comments before. Will look into this issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d86c41c23e4e93a84e0527d7cddcfd30d5d8394
Gerrit-Change-Number: 33252
Gerrit-PatchSet: 8
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Sep 2019 07:10:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment