Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mainboard/asus: Add ASUS H110M-E/M.2 mainboard
......................................................................
Patch Set 45:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34603/45/Documentation/mainboard/as...
File Documentation/mainboard/asus/h110m-e_m2.md:
https://review.coreboot.org/c/coreboot/+/34603/45/Documentation/mainboard/as...
PS45, Line 1: # ASUS H110M-E/M.2
document must be referenced from existing document, for example index.md
https://review.coreboot.org/c/coreboot/+/34603/45/Documentation/mainboard/as...
PS45, Line 67: The flash chip is a 16 MiB socketed DIP-8 chip. Specifically, it's a
can you provide a picture showing the position of the flash IC?
It should be no bigger than 800px in width and have a low quality level.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8fa41ecccaa8dba8dc2158ce62d328c7928e05c
Gerrit-Change-Number: 34603
Gerrit-PatchSet: 45
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 22 Aug 2019 14:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment