Attention is currently required from: Ashish Kumar Mishra, Deepti Deshatty, Eric Herrmann, Karthik Ramasubramanian, Shelley Chen.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )
Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83406/comment/dbd0ca7f_9737e82d?usp... :
PS2, Line 161: soc_config->tdp_pl4 -= POWER_LIMIT_TUNE;
Are you adjusting twice for PL4 - especially when PL4 > PL3? PL3 got adjusted in line 151. […]
Yes this intentional .It is recommended that Psyspl3 is set above psyspl2 by 1 or 2 Low PL4 does not cause functional failure but result in a loss in max obtainable frequency .A lower PL4 ensures that going lower than battery min voltage is prevented
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0074bfc97c54f07d0b7257393de7c355e36b262
Gerrit-Change-Number: 83406
Gerrit-PatchSet: 4
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 17 Jul 2024 10:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com