Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email )
Change subject: mb/google/rauru: Enable firmware display
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85952/comment/510d12fe_01162515?usp... :
PS1, Line 103: mt6373_init_pmif_arb();
SD card actually needs `mt6373_init_pmif_arb` for the regulator enablement.
@yupingso, do you suggest move this to line 102 or spend a separate patch for SD card ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85952?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036
Gerrit-Change-Number: 85952
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 13 Jan 2025 10:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No