Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32501 )
Change subject: include: Implement abs()
......................................................................
Patch Set 3:
Patch Set 3:
There is an abs() in commonlib/helpers.h, please base this off that.
I tried to use ABS instead of abs(), but it doesn't work as the 3rdparty library depends on the C89 function signature and the casts implicitly done usingthis function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0719de6558cf9224ecbbd46b6f8a8040e8225a79
Gerrit-Change-Number: 32501
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jul 2019 16:22:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment