Martin Roth (martinroth@google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14194
-gerrit
commit 1c4607911c3e4c5a38d9fd56bb45784615b39be1 Author: Martin Roth martinroth@google.com Date: Wed Mar 30 13:56:23 2016 -0600
lint/lint-stable-004-style-labels: Update script
- Look at entire tree instead of just the current commit. This was causing the test to overlook some issues that were already in the tree. - Use find instead of git to get the list of files so this check will work on new files as well. - Wrap the command so it's easier to read.
Change-Id: I3dce219a29ffb1ae56a31318b995e3ba8ea43e70 Signed-off-by: Martin Roth martinroth@google.com --- util/lint/lint-stable-004-style-labels | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/lint/lint-stable-004-style-labels b/util/lint/lint-stable-004-style-labels index f024ca1..35814d8 100755 --- a/util/lint/lint-stable-004-style-labels +++ b/util/lint/lint-stable-004-style-labels @@ -2,6 +2,7 @@ # This file is part of the coreboot project. # # Copyright (C) 2012 Patrick Georgi patrick@georgi-clan.de +# Copyright (C) 2016 Google Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -15,4 +16,8 @@ # DESCR: Check that C labels begin at start-of-line
LC_ALL=C export LC_ALL -git diff --name-status |grep -v "^D" |cut -c3- |grep "^src/.*.[csS]" | xargs grep -Hn '^[[:space:]][[:space:]]*[a-z][a-z]*:[[:space:]]*$' |grep -v "[^a-z_]default:" + +find src | \ + grep "^src/.*.[csS]" | \ + xargs grep -Hn '^[[:space:]][[:space:]]*[a-z][a-z]*:[[:space:]]*$' | \ + grep -v "[^a-z_]default:"