Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86238?usp=email )
Change subject: mb/starlabs/starbook/mtl: Correct USB Port Configuration ......................................................................
mb/starlabs/starbook/mtl: Correct USB Port Configuration
These were initially configured incorrectly; adjust them to match the schematic: * Front USB-C: USB2-1 / TCP0 * Back USB-C: USB2-2 / TCP1 * Left USB-A: USB2-3 / USB3-1 * Right USB-A: USB2-7 / USB3-2 * SD Card: USB2-4 * Webcam: USB2-5 * Bluetooth: USB2-10
TEST=boot starbook/mtl, check USB-C and USB-A function, enter/exit S3.
Change-Id: I882d70a1d7db0af7ff8e344a3c42a2a9e62df4e8 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86238 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb 1 file changed, 9 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb index 86605ec..a138438 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb @@ -34,13 +34,13 @@ chip drivers/usb/acpi device ref tcss_root_hub on chip drivers/usb/acpi - register "desc" = ""USB Type-C"" + register "desc" = ""Front USB Type-C"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(0, 0)" device ref tcss_usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""USB Type-C"" + register "desc" = ""Back USB Type-C"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(0, 1)" device ref tcss_usb3_port2 on end @@ -55,11 +55,11 @@ register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC_SKIP)"
# Motherboard USB 3.0 Type-C Back 7893 mil - register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC_SKIP)" + register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC_SKIP)" register "tcss_ports[1]" = "TCSS_PORT_DEFAULT(OC_SKIP)"
# Motherboard USB 3.0 Type-A 8916 mil - register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)"
# Daughterboard USB 3.0 Type-A 2229 mil @@ -78,22 +78,22 @@ chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""USB Type-C"" + register "desc" = ""Front USB Type-C"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(0, 0)" device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""USB Type-C"" + register "desc" = ""Back USB Type-C"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(0, 1)" - device ref usb2_port3 on end + device ref usb2_port2 on end end chip drivers/usb/acpi register "desc" = ""Left USB Type-A"" register "type" = "UPC_TYPE_USB3_A" register "group" = "ACPI_PLD_GROUP(0, 2)" - device ref usb2_port2 on end + device ref usb2_port3 on end end chip drivers/usb/acpi register "desc" = ""Left USB Type-A"" @@ -240,7 +240,7 @@ device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn - use usb2_port3 as usb2_port + use usb2_port2 as usb2_port use tcss_usb3_port2 as usb3_port device generic 1 alias conn1 on end end